From b91ecdfe42000558da9ae16a29301a542521dd4a Mon Sep 17 00:00:00 2001 From: TrisNol Date: Sat, 9 Sep 2023 09:57:43 +0200 Subject: [PATCH] test(data-ingestion): Fix myPy complaints regarding tests --- .../utils/mongo/company_mongo_service.py | 4 ++-- tests/utils/mongo/company_mongo_service_test.py | 9 +++++++-- 2 files changed, 9 insertions(+), 4 deletions(-) diff --git a/src/aki_prj23_transparenzregister/utils/mongo/company_mongo_service.py b/src/aki_prj23_transparenzregister/utils/mongo/company_mongo_service.py index 2c7d1db..c2641bb 100644 --- a/src/aki_prj23_transparenzregister/utils/mongo/company_mongo_service.py +++ b/src/aki_prj23_transparenzregister/utils/mongo/company_mongo_service.py @@ -4,7 +4,7 @@ from threading import Lock from bson.objectid import ObjectId from pymongo.results import InsertOneResult, UpdateResult -from aki_prj23_transparenzregister.models.company import Company, CompanyID +from aki_prj23_transparenzregister.models.company import Company from aki_prj23_transparenzregister.utils.mongo.connector import MongoConnector @@ -30,7 +30,7 @@ class CompanyMongoService: result = self.collection.find() return list(result) - def get_by_id(self, id: CompanyID) -> Company | None: + def get_by_id(self, id: str) -> Company | None: """_summary_. Args: diff --git a/tests/utils/mongo/company_mongo_service_test.py b/tests/utils/mongo/company_mongo_service_test.py index ba761e0..aa75949 100644 --- a/tests/utils/mongo/company_mongo_service_test.py +++ b/tests/utils/mongo/company_mongo_service_test.py @@ -3,7 +3,7 @@ from unittest.mock import Mock import pytest -from aki_prj23_transparenzregister.models.company import Company +from aki_prj23_transparenzregister.models.company import Company, CompanyID, Location from aki_prj23_transparenzregister.utils.mongo.company_mongo_service import ( CompanyMongoService, ) @@ -101,7 +101,12 @@ def test_insert(mock_mongo_connector: Mock, mock_collection: Mock) -> None: service = CompanyMongoService(mock_mongo_connector) mock_result = 42 mock_collection.insert_one.return_value = mock_result - assert service.insert(Company(None, None, "", "", [])) == mock_result + assert ( + service.insert( + Company(CompanyID("", ""), Location("Hier und Dort"), "", "", []) + ) + == mock_result + ) def test_get_by_object_id_no_result(