fix: decode console output to ensure tracebacks are detected even when encoded

dist/index.js

@@ -97,4 +97,4 @@ var re=z(20181);var Pe=re.Buffer;function copyProps(i,_){for(var z in i){_[z]=i[
  * @license [MIT]{@link https://github.com/archiverjs/node-zip-stream/blob/master/LICENSE}
  * @copyright (c) 2014 Chris Talkington, contributors.
  */
-var re=z(39023).inherits;var Pe=z(47544).ZipArchiveOutputStream;var $t=z(47544).ZipArchiveEntry;var er=z(53296);var tr=i.exports=function(i){if(!(this instanceof tr)){return new tr(i)}i=this.options=i||{};i.zlib=i.zlib||{};Pe.call(this,i);if(typeof i.level==="number"&&i.level>=0){i.zlib.level=i.level;delete i.level}if(!i.forceZip64&&typeof i.zlib.level==="number"&&i.zlib.level===0){i.store=true}i.namePrependSlash=i.namePrependSlash||false;if(i.comment&&i.comment.length>0){this.setComment(i.comment)}};re(tr,Pe);tr.prototype._normalizeFileData=function(i){i=er.defaults(i,{type:"file",name:null,namePrependSlash:this.options.namePrependSlash,linkname:null,date:null,mode:null,store:this.options.store,comment:""});var _=i.type==="directory";var z=i.type==="symlink";if(i.name){i.name=er.sanitizePath(i.name);if(!z&&i.name.slice(-1)==="/"){_=true;i.type="directory"}else if(_){i.name+="/"}}if(_||z){i.store=true}i.date=er.dateify(i.date);return i};tr.prototype.entry=function(i,_,z){if(typeof z!=="function"){z=this._emitErrorCallback.bind(this)}_=this._normalizeFileData(_);if(_.type!=="file"&&_.type!=="directory"&&_.type!=="symlink"){z(new Error(_.type+" entries not currently supported"));return}if(typeof _.name!=="string"||_.name.length===0){z(new Error("entry name must be a non-empty string value"));return}if(_.type==="symlink"&&typeof _.linkname!=="string"){z(new Error("entry linkname must be a non-empty string value when type equals symlink"));return}var re=new $t(_.name);re.setTime(_.date,this.options.forceLocalTime);if(_.namePrependSlash){re.setName(_.name,true)}if(_.store){re.setMethod(0)}if(_.comment.length>0){re.setComment(_.comment)}if(_.type==="symlink"&&typeof _.mode!=="number"){_.mode=40960}if(typeof _.mode==="number"){if(_.type==="symlink"){_.mode|=40960}re.setUnixMode(_.mode)}if(_.type==="symlink"&&typeof _.linkname==="string"){i=Buffer.from(_.linkname)}return Pe.prototype.entry.call(this,re,i,z)};tr.prototype.finalize=function(){this.finish()}},42078:module=>{module.exports=eval("require")("encoding")},42613:i=>{i.exports=__WEBPACK_EXTERNAL_createRequire(import.meta.url)("assert")},90290:i=>{i.exports=__WEBPACK_EXTERNAL_createRequire(import.meta.url)("async_hooks")},20181:i=>{i.exports=__WEBPACK_EXTERNAL_createRequire(import.meta.url)("buffer")},77969:i=>{i.exports=__WEBPACK_EXTERNAL_createRequire(import.meta.url)("bufferutil")},35317:i=>{i.exports=__WEBPACK_EXTERNAL_createRequire(import.meta.url)("child_process")},64236:i=>{i.exports=__WEBPACK_EXTERNAL_createRequire(import.meta.url)("console")},49140:i=>{i.exports=__WEBPACK_EXTERNAL_createRequire(import.meta.url)("constants")},76982:i=>{i.exports=__WEBPACK_EXTERNAL_createRequire(import.meta.url)("crypto")},31637:i=>{i.exports=__WEBPACK_EXTERNAL_createRequire(import.meta.url)("diagnostics_channel")},24434:i=>{i.exports=__WEBPACK_EXTERNAL_createRequire(import.meta.url)("events")},79896:i=>{i.exports=__WEBPACK_EXTERNAL_createRequire(import.meta.url)("fs")},91943:i=>{i.exports=__WEBPACK_EXTERNAL_createRequire(import.meta.url)("fs/promises")},58611:i=>{i.exports=__WEBPACK_EXTERNAL_createRequire(import.meta.url)("http")},85675:i=>{i.exports=__WEBPACK_EXTERNAL_createRequire(import.meta.url)("http2")},65692:i=>{i.exports=__WEBPACK_EXTERNAL_createRequire(import.meta.url)("https")},69278:i=>{i.exports=__WEBPACK_EXTERNAL_createRequire(import.meta.url)("net")},34589:i=>{i.exports=__WEBPACK_EXTERNAL_createRequire(import.meta.url)("node:assert")},16698:i=>{i.exports=__WEBPACK_EXTERNAL_createRequire(import.meta.url)("node:async_hooks")},4573:i=>{i.exports=__WEBPACK_EXTERNAL_createRequire(import.meta.url)("node:buffer")},37540:i=>{i.exports=__WEBPACK_EXTERNAL_createRequire(import.meta.url)("node:console")},77598:i=>{i.exports=__WEBPACK_EXTERNAL_createRequire(import.meta.url)("node:crypto")},53053:i=>{i.exports=__WEBPACK_EXTERNAL_createRequire(import.meta.url)("node:diagnostics_channel")},40610:i=>{i.exports=__WEBPACK_EXTERNAL_createRequire(import.meta.url)("node:dns")},78474:i=>{i.exports=__WEBPACK_EXTERNAL_createRequire(import.meta.url)("node:events")},73024:i=>{i.exports=__WEBPACK_EXTERNAL_createRequire(import.meta.url)("node:fs")},51455:i=>{i.exports=__WEBPACK_EXTERNAL_createRequire(import.meta.url)("node:fs/promises")},37067:i=>{i.exports=__WEBPACK_EXTERNAL_createRequire(import.meta.url)("node:http")},32467:i=>{i.exports=__WEBPACK_EXTERNAL_createRequire(import.meta.url)("node:http2")},44708:i=>{i.exports=__WEBPACK_EXTERNAL_createRequire(import.meta.url)("node:https")},77030:i=>{i.exports=__WEBPACK_EXTERNAL_createRequire(import.meta.url)("node:net")},48161:i=>{i.exports=__WEBPACK_EXTERNAL_createRequire(import.meta.url)("node:os")},76760:i=>{i.exports=__WEBPACK_EXTERNAL_createRequire(import.meta.url)("node:path")},643:i=>{i.exports=__WEBPACK_EXTERNAL_createRequire(import.meta.url)("node:perf_hooks")},1708:i=>{i.exports=__WEBPACK_EXTERNAL_createRequire(import.meta.url)("node:process")},41792:i=>{i.exports=__WEBPACK_EXTERNAL_createRequire(import.meta.url)("node:queryLine truncated
+var re=z(39023).inherits;var Pe=z(47544).ZipArchiveOutputStream;var $t=z(47544).ZipArchiveEntry;var er=z(53296);var tr=i.exports=function(i){if(!(this instanceof tr)){return new tr(i)}i=this.options=i||{};i.zlib=i.zlib||{};Pe.call(this,i);if(typeof i.level==="number"&&i.level>=0){i.zlib.level=i.level;delete i.level}if(!i.forceZip64&&typeof i.zlib.level==="number"&&i.zlib.level===0){i.store=true}i.namePrependSlash=i.namePrependSlash||false;if(i.comment&&i.comment.length>0){this.setComment(i.comment)}};re(tr,Pe);tr.prototype._normalizeFileData=function(i){i=er.defaults(i,{type:"file",name:null,namePrependSlash:this.options.namePrependSlash,linkname:null,date:null,mode:null,store:this.options.store,comment:""});var _=i.type==="directory";var z=i.type==="symlink";if(i.name){i.name=er.sanitizePath(i.name);if(!z&&i.name.slice(-1)==="/"){_=true;i.type="directory"}else if(_){i.name+="/"}}if(_||z){i.store=true}i.date=er.dateify(i.date);return i};tr.prototype.entry=function(i,_,z){if(typeof z!=="function"){z=this._emitErrorCallback.bind(this)}_=this._normalizeFileData(_);if(_.type!=="file"&&_.type!=="directory"&&_.type!=="symlink"){z(new Error(_.type+" entries not currently supported"));return}if(typeof _.name!=="string"||_.name.length===0){z(new Error("entry name must be a non-empty string value"));return}if(_.type==="symlink"&&typeof _.linkname!=="string"){z(new Error("entry linkname must be a non-empty string value when type equals symlink"));return}var re=new $t(_.name);re.setTime(_.date,this.options.forceLocalTime);if(_.namePrependSlash){re.setName(_.name,true)}if(_.store){re.setMethod(0)}if(_.comment.length>0){re.setComment(_.comment)}if(_.type==="symlink"&&typeof _.mode!=="number"){_.mode=40960}if(typeof _.mode==="number"){if(_.type==="symlink"){_.mode|=40960}re.setUnixMode(_.mode)}if(_.type==="symlink"&&typeof _.linkname==="string"){i=Buffer.from(_.linkname)}return Pe.prototype.entry.call(this,re,i,z)};tr.prototype.finalize=function(){this.finish()}},42078:module=>{module.exports=eval("require")("encoding")},42613:i=>{i.exports=__WEBPACK_EXTERNAL_createRequire(import.meta.url)("assert")},90290:i=>{i.exports=__WEBPACK_EXTERNAL_createRequire(import.meta.url)("async_hooks")},20181:i=>{i.exports=__WEBPACK_EXTERNAL_createRequire(import.meta.url)("buffer")},77969:i=>{i.exports=__WEBPACK_EXTERNAL_createRequire(import.meta.url)("bufferutil")},35317:i=>{i.exports=__WEBPACK_EXTERNAL_createRequire(import.meta.url)("child_process")},64236:i=>{i.exports=__WEBPACK_EXTERNAL_createRequire(import.meta.url)("console")},49140:i=>{i.exports=__WEBPACK_EXTERNAL_createRequire(import.meta.url)("constants")},76982:i=>{i.exports=__WEBPACK_EXTERNAL_createRequire(import.meta.url)("crypto")},31637:i=>{i.exports=__WEBPACK_EXTERNAL_createRequire(import.meta.url)("diagnostics_channel")},24434:i=>{i.exports=__WEBPACK_EXTERNAL_createRequire(import.meta.url)("events")},79896:i=>{i.exports=__WEBPACK_EXTERNAL_createRequire(import.meta.url)("fs")},91943:i=>{i.exports=__WEBPACK_EXTERNAL_createRequire(import.meta.url)("fs/promises")},58611:i=>{i.exports=__WEBPACK_EXTERNAL_createRequire(import.meta.url)("http")},85675:i=>{i.exports=__WEBPACK_EXTERNAL_createRequire(import.meta.url)("http2")},65692:i=>{i.exports=__WEBPACK_EXTERNAL_createRequire(import.meta.url)("https")},69278:i=>{i.exports=__WEBPACK_EXTERNAL_createRequire(import.meta.url)("net")},34589:i=>{i.exports=__WEBPACK_EXTERNAL_createRequire(import.meta.url)("node:assert")},16698:i=>{i.exports=__WEBPACK_EXTERNAL_createRequire(import.meta.url)("node:async_hooks")},4573:i=>{i.exports=__WEBPACK_EXTERNAL_createRequire(import.meta.url)("node:buffer")},37540:i=>{i.exports=__WEBPACK_EXTERNAL_createRequire(import.meta.url)("node:console")},77598:i=>{i.exports=__WEBPACK_EXTERNAL_createRequire(import.meta.url)("node:crypto")},53053:i=>{i.exports=__WEBPACK_EXTERNAL_createRequire(import.meta.url)("node:diagnostics_channel")},40610:i=>{i.exports=__WEBPACK_EXTERNAL_createRequire(import.meta.url)("node:dns")},78474:i=>{i.exports=__WEBPACK_EXTERNAL_createRequire(import.meta.url)("node:events")},73024:i=>{i.exports=__WEBPACK_EXTERNAL_createRequire(import.meta.url)("node:fs")},51455:i=>{i.exports=__WEBPACK_EXTERNAL_createRequire(import.meta.url)("node:fs/promises")},37067:i=>{i.exports=__WEBPACK_EXTERNAL_createRequire(import.meta.url)("node:http")},32467:i=>{i.exports=__WEBPACK_EXTERNAL_createRequire(import.meta.url)("node:http2")},44708:i=>{i.exports=__WEBPACK_EXTERNAL_createRequire(import.meta.url)("node:https")},77030:i=>{i.exports=__WEBPACK_EXTERNAL_createRequire(import.meta.url)("node:net")},48161:i=>{i.exports=__WEBPACK_EXTERNAL_createRequire(import.meta.url)("node:os")},76760:i=>{i.exports=__WEBPACK_EXTERNAL_createRequire(import.meta.url)("node:path")},643:i=>{i.exports=__WEBPACK_EXTERNAL_createRequire(import.meta.url)("node:perf_hooks")},1708:i=>{i.exports=__WEBPACK_EXTERNAL_createRequire(import.meta.url)("node:process")},41792:i=>{i.exports=__WEBPACK_EXTERNAL_createRequire(import.meta.url)("node:queryLine truncated

index.js

@@ -197,7 +197,7 @@ export async function postCode() {
       });
   }
 
-  // Console monitoring (optional)
+  // ── Console monitoring (optional) ────────────────────────────────────────
   const monitorTicks = parseInt(core.getInput("monitor") || "0", 10);
   if (monitorTicks > 0) {
     const result = await monitorConsole(api, {

monitor.js

@@ -4,6 +4,10 @@ import fs from "fs";
 import path from "path";
 import os from "os";
 
+// ────────────────────────────────────────────────────────────────────────────
+// Shard / subscribe-path helpers
+// ────────────────────────────────────────────────────────────────────────────
+
 /**
  * Returns true if the hostname is the official Screeps server.
  * Used to decide whether to prefix the subscribe path with a shard name.
@@ -33,6 +37,10 @@ export function buildSubscribePath(hostname, shard) {
   return isOfficialServer(hostname) ? "shard0/console" : "console";
 }
 
+// ────────────────────────────────────────────────────────────────────────────
+// Detection helpers
+// ────────────────────────────────────────────────────────────────────────────
+
 /**
  * Returns true when errorText contains JavaScript stack-frame lines.
  * Screeps places runtime errors (including stack traces) in event.data.error.
@@ -68,38 +76,17 @@ export function detectWarning(logLines) {
  * @returns {string}
  */
 export function safeDecode(text) {
-  if (typeof text !== "string") return text;
+  if (typeof text !== "string" || !text.includes("%")) return text;
-  let result = text;
-  if (result.includes("%")) {
   try {
-      result = decodeURIComponent(result);
+    return decodeURIComponent(text);
   } catch (err) {
-      // Ignore decoding errors
+    return text;
   }
-  }
-  // Screeps console often contains HTML entities
-  return result
-    .replace(/&lt;/g, "<")
-    .replace(/&gt;/g, ">")
-    .replace(/&quot;/g, '"')
-    .replace(/&amp;/g, "&");
 }
 
-/**
+// ────────────────────────────────────────────────────────────────────────────
- * Outputs text to the action log, splitting by newline to ensure proper display.
+// Output helpers
- *
+// ────────────────────────────────────────────────────────────────────────────
- * @param {string} text
- * @param {"info"|"warning"|"error"} level
- */
-export function outputMultiline(text, level = "info") {
-  if (!text) return;
-  const lines = text.split(/\r?\n/);
-  lines.forEach((line) => {
-    if (level === "error") core.error(line);
-    else if (level === "warning") core.warning(line);
-    else core.info(line);
-  });
-}
 
 /**
  * Builds a CI-friendly progress string for core.info().
@@ -112,6 +99,10 @@ export function buildProgressMessage(elapsed, total) {
   return `[Monitor] ${elapsed}/${total} ticks elapsed...`;
 }
 
+// ────────────────────────────────────────────────────────────────────────────
+// File / artifact helpers
+// ────────────────────────────────────────────────────────────────────────────
+
 /**
  * Writes an array of log lines to a UTF-8 text file, one line per entry.
  *
@@ -151,6 +142,10 @@ export async function uploadLogArtifact(
   }
 }
 
+// ────────────────────────────────────────────────────────────────────────────
+// Console event handler
+// ────────────────────────────────────────────────────────────────────────────
+
 /**
  * Processes a single 'console' WebSocket event from the Screeps socket.
  * Mutates `state` and `stdoutBuffer` in place; never throws.
@@ -184,42 +179,46 @@ export function handleConsoleEvent(event, opts, stdoutBuffer, state) {
   const results = data?.messages?.results ?? [];
   const errorText = data?.error ?? null;
 
-  // Warn detection (always live regardless of logToFile)
+  // ── Warn detection (always live regardless of logToFile) ─────────────────
   if (detectWarning(logLines)) {
     state.sawWarningLog = true;
     const warnPattern = /<font\s+color=['"](?:orange|yellow)['"]/i;
     logLines
       .filter((l) => warnPattern.test(l))
-      .forEach((l) => outputMultiline(safeDecode(l), "warning"));
+      .forEach((l) => core.warning(safeDecode(l)));
   }
 
-  // Traceback detection in log lines (Screeps sometimes sends errors here)
+  // ── Traceback detection in log lines (Screeps sometimes sends errors here) ─
   if (logLines.some((l) => detectTraceback(l))) {
     state.sawTraceback = true;
     state.sawErrorLog = true;
   }
 
-  // Stdout lines
+  // ── Stdout lines ──────────────────────────────────────────────────────────
   const allStdout = [...logLines, ...results].map(safeDecode);
   if (allStdout.length > 0) {
     if (logToFile) {
       stdoutBuffer.push(...allStdout);
     } else {
-      allStdout.forEach((l) => outputMultiline(l, "info"));
+      allStdout.forEach((l) => core.info(l));
     }
   }
 
-  // Error field (always live)
+  // ── Error field (always live) ─────────────────────────────────────────────
   if (errorText) {
     state.sawErrorLog = true;
     const decodedError = safeDecode(errorText);
-    outputMultiline(decodedError, "error");
+    core.error(decodedError);
     if (detectTraceback(decodedError)) {
       state.sawTraceback = true;
     }
   }
 }
 
+// ────────────────────────────────────────────────────────────────────────────
+// Tick polling
+// ────────────────────────────────────────────────────────────────────────────
+
 /**
  * Sleeps for the given number of milliseconds.
  *
@@ -263,6 +262,10 @@ export async function pollUntilDone(
   return elapsed;
 }
 
+// ────────────────────────────────────────────────────────────────────────────
+// Main orchestrator
+// ────────────────────────────────────────────────────────────────────────────
+
 /**
  * @typedef {Object} MonitorOptions
  * @property {number}  monitor         - Number of game ticks to collect.
@@ -322,10 +325,10 @@ export async function monitorConsole(api, opts) {
   };
   let lastProgressTick = 0;
 
-  // Step 1: record starting tick
+  // ── Step 1: record starting tick ─────────────────────────────────────────
   const { time: startTick } = await api.time(shard);
 
-  // Step 2: connect socket + subscribe
+  // ── Step 2: connect socket + subscribe ───────────────────────────────────
   await api.socket.connect();
   await api.socket.subscribe(subscribePath, (event) => {
     handleConsoleEvent(event, opts, stdoutBuffer, state);
@@ -337,7 +340,7 @@ export async function monitorConsole(api, opts) {
       "...",
   );
 
-  // Step 3 & 4: tick-poll loop
+  // ── Step 3 & 4: tick-poll loop ───────────────────────────────────────────
   try {
     await pollUntilDone(
       api,
@@ -365,16 +368,13 @@ export async function monitorConsole(api, opts) {
       },
     );
   } finally {
-    // Step 5: always disconnect cleanly
+    // ── Step 5: always disconnect cleanly ────────────────────────────────
     api.socket.disconnect();
   }
 
-  // Step 6: artifact upload
+  // ── Step 6: artifact upload ───────────────────────────────────────────────
   if (logToFile && stdoutBuffer.length > 0) {
-    const tmpDir = await fs.promises.mkdtemp(
+    const tmpFile = path.join(os.tmpdir(), "screeps_console_log.txt");
-      path.join(os.tmpdir(), "screeps-monitor-"),
-    );
-    const tmpFile = path.join(tmpDir, "screeps_console_log.txt");
     await writeLogFile(stdoutBuffer, tmpFile);
     await uploadLogArtifact(tmpFile);
   } else if (logToFile) {

package.json

@@ -1,7 +1,7 @@
 {
   "name": "screeps-deploy-action",
   "version": "0.2.0",
-  "description": "Deploys screeps code to the official game or a private server.",
+  "description": "Deploys screeps code to the official game or an pirvate server.",
   "type": "module",
   "main": "index.js",
   "scripts": {