Screeps/screeps-deploy-action
4
1
Fork 0
Code Issues 1 Pull Requests 4 Actions Packages Releases 4 Activity

ci: delegate pre-commit linting to central global scoped workflow #119

Merged
Philipp merged 1 commits from ci/remove-redundant-lint-workflow into main 2026-08-31 23:28:52 +02:00
Conversation 2 Commits 1 Files Changed 1
-18
Philipp commented 2026-08-31 23:02:06 +02:00
Owner
Copy Link
Copy Source

This PR removes the redundant local workflow file (.gitea/workflows/lint.yaml) in favor of the central Global Scoped Workflow hosted in Global-Workflows (.gitea/scoped_workflows/lint.yaml).

Checklist

  • I changed the Branch protections to fit the new pipeline setup.
This PR removes the redundant local workflow file (`.gitea/workflows/lint.yaml`) in favor of the central **Global Scoped Workflow** hosted in `Global-Workflows` (`.gitea/scoped_workflows/lint.yaml`). ### Checklist - [x] I changed the Branch protections to fit the new pipeline setup.
Philipp added 1 commit 2026-08-31 23:02:06 +02:00
ci: remove redundant .gitea/workflows/lint.yaml in favor of global scoped workflow
Test / Run Tests (push) Successful in 4m18s
Details
Philipp/Global-Workflows: Pre-commit Lint (Scoped) / pre-commit (pull_request) Successful in 2m39s
Details
9678689f50
CODEOWNERS rules requested review from AutoReview 2026-08-31 23:02:06 +02:00
Philipp added 1 commit 2026-08-31 23:02:07 +02:00
ci: remove redundant .gitea/workflows/lint.yaml in favor of global scoped workflow
Test / Run Tests (push) Successful in 4m18s
Details
Philipp/Global-Workflows: Pre-commit Lint (Scoped) / pre-commit (pull_request) Successful in 2m39s
Details
9678689f50
AutoReview approved these changes 2026-08-31 23:02:12 +02:00
Dismissed
AutoReview left a comment
Member
Copy Link
Copy Source

Summary

  • Critical: None. The removal of the redundant local linting workflow is acceptable, provided the responsibility has been successfully delegated to a central global workflow as described in the PR.
  • Testing: No new tests are required as this is a configuration cleanup.
  • Improvement: Ensure that the documentation or README is updated if any references to the local lint.yaml existed, to avoid confusion for contributors.
  • Nitpick: None.

The change aligns with the goal of centralizing CI configuration.

Approved.

**Summary** * **Critical:** None. The removal of the redundant local linting workflow is acceptable, provided the responsibility has been successfully delegated to a central global workflow as described in the PR. * **Testing:** No new tests are required as this is a configuration cleanup. * **Improvement:** Ensure that the documentation or README is updated if any references to the local `lint.yaml` existed, to avoid confusion for contributors. * **Nitpick:** None. The change aligns with the goal of centralizing CI configuration. Approved.
AutoReview approved these changes 2026-08-31 23:02:14 +02:00
AutoReview left a comment
Member
Copy Link
Copy Source

Summary

  • Critical: None. The removal of the local lint.yaml workflow is appropriate given the stated goal of delegating pre-commit linting to a centralized workflow.
  • Testing: No new tests required as this is a configuration cleanup. Existing tests in .gitea/workflows/test.yaml should remain unaffected.
  • Improvement: Ensure that the centralized workflow that is now responsible for pre-commit runs has sufficient visibility into this repository's configuration.
  • Nitpick: None.

This PR effectively reduces technical debt by removing redundant CI configuration. The changes are straightforward and correctly implemented.

**Summary** * **Critical:** None. The removal of the local `lint.yaml` workflow is appropriate given the stated goal of delegating pre-commit linting to a centralized workflow. * **Testing:** No new tests required as this is a configuration cleanup. Existing tests in `.gitea/workflows/test.yaml` should remain unaffected. * **Improvement:** Ensure that the centralized workflow that is now responsible for `pre-commit` runs has sufficient visibility into this repository's configuration. * **Nitpick:** None. This PR effectively reduces technical debt by removing redundant CI configuration. The changes are straightforward and correctly implemented.
Philipp scheduled this pull request to auto merge when all checks succeed 2026-08-31 23:11:28 +02:00
Philipp merged commit 7c5cb5ffec into main 2026-08-31 23:28:52 +02:00
Philipp deleted branch ci/remove-redundant-lint-workflow 2026-08-31 23:28:52 +02:00
Sign in to join this conversation.
Reviewers
No Reviewers
AutoReview
Labels
Clear labels
bug
Something is not working
 chore
duplicate
This issue or pull request already exists
 enhancement
New feature
 help wanted
Need some help
 invalid
Something is wrong
 question
More information is needed
 wontfix
This won't be fixed
No labels
Milestone
No items
No Milestone
Assignees
Clear assignees
AutoReview (LLMReview) Philipp (Philipp Horstenkamp) Renovate (Renovate Bot) runner (Act Runner)
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Screeps/screeps-deploy-action#119