Screeps/screeps-deploy-action
4
1
Fork 0
Code Issues 1 Pull Requests 3 Actions Packages Releases 4 Activity

feat: automate dist recompilation on Renovate PRs and configure concurrency limit #120

Merged
Philipp merged 5 commits from feature/renovate-recompile-dist into main 2026-09-04 23:20:17 +02:00
Conversation 4 Commits 5 Files Changed 7
+130 -76
Philipp commented 2026-09-04 22:33:28 +02:00
Owner
Copy Link
Copy Source

Summary of Changes

  1. Gitea Workflow (.gitea/workflows/recompile-dist.yaml):
    • Automates recompilation of dist/index.js on Renovate PRs.
    • Adds loop-prevention check for [skip compile].
  2. Renovate Configuration (
    enovate.json)    :
    • Configures branchConcurrentLimit: 2 and prConcurrentLimit: 2.
    • Adds gitIgnoredAuthors for automated bot commits.
    • Adds rebaseWhen: 'behind-base-branch'.
    • Removes postUpgradeTasks.
  3. Test Workflow (.gitea/workflows/test.yaml):
    • Added pull_request trigger.
  4. Gitea-Only Setup:
    • Removed .github/ workflows to keep workflow execution strictly on Gitea.
  5. Preferences (GEMINI.md):
    • Documented strict pnpm/pnpx rule.
  6. Tests:
    • Added afterEach import in tests/index.test.js.
### Summary of Changes 1. **Gitea Workflow (.gitea/workflows/recompile-dist.yaml)**: - Automates recompilation of dist/index.js on Renovate PRs. - Adds loop-prevention check for [skip compile]. 2. **Renovate Configuration ( enovate.json)**: - Configures branchConcurrentLimit: 2 and prConcurrentLimit: 2. - Adds gitIgnoredAuthors for automated bot commits. - Adds rebaseWhen: 'behind-base-branch'. - Removes postUpgradeTasks. 3. **Test Workflow (.gitea/workflows/test.yaml)**: - Added pull_request trigger. 4. **Gitea-Only Setup**: - Removed .github/ workflows to keep workflow execution strictly on Gitea. 5. **Preferences (GEMINI.md)**: - Documented strict pnpm/pnpx rule. 6. **Tests**: - Added afterEach import in __tests__/index.test.js.
Philipp added 2 commits 2026-09-04 22:33:29 +02:00
feat: automate dist recompilation on Renovate PRs and configure concurrency limit 00e2484118
chore: remove .github workflows in favor of Gitea-only workflows
Philipp/Global-Workflows: Pre-commit Lint (Scoped) / pre-commit (pull_request) Successful in 3m57s
Details
Test / Run Tests (push) Successful in 6m5s
Details
Test / Run Tests (pull_request) Successful in 9m19s
Details
08be5fe521
CODEOWNERS rules requested review from AutoReview 2026-09-04 22:33:29 +02:00
AutoReview approved these changes 2026-09-04 22:33:35 +02:00
Dismissed
AutoReview left a comment
Member
Copy Link
Copy Source

Summary

  • Critical: None.
  • Testing: The new workflow covers the build process, but it should ideally be tested to ensure the commit logic handles empty changes or transient failures gracefully.
  • Improvement:
    • The permissions block in recompile-dist.yaml is correctly scoped, but ensure that the Gitea runner token has the contents: write scope configured at the repository level.
    • The workflow triggers on push and pull_request for test.yaml, which is good practice.
  • Nitpick: None.

The automation strategy replaces the older postUpgradeTasks in renovate.json with a cleaner Gitea workflow approach, which is more reliable for long-running builds. The implementation looks sound.

**Summary** * **Critical:** None. * **Testing:** The new workflow covers the build process, but it should ideally be tested to ensure the commit logic handles empty changes or transient failures gracefully. * **Improvement:** * The `permissions` block in `recompile-dist.yaml` is correctly scoped, but ensure that the Gitea runner token has the `contents: write` scope configured at the repository level. * The workflow triggers on `push` and `pull_request` for `test.yaml`, which is good practice. * **Nitpick:** None. The automation strategy replaces the older `postUpgradeTasks` in `renovate.json` with a cleaner Gitea workflow approach, which is more reliable for long-running builds. The implementation looks sound.
.gitea/workflows/recompile-dist.yaml
@@ -0,0 +45,4 @@
git config user.email "github-actions[bot]@users.noreply.github.com"
git add dist/
if git diff --staged --quiet; then
echo "No changes to dist/"
AutoReview commented 2026-09-04 22:33:35 +02:00
Member
Copy Link
Copy Source

The use of [skip compile] in the commit message is a good way to prevent circular workflow triggers. Ensure this is consistent if you add other workflows that commit back to the repo.

The use of `[skip compile]` in the commit message is a good way to prevent circular workflow triggers. Ensure this is consistent if you add other workflows that commit back to the repo.
Philipp marked this conversation as resolved
Philipp added 1 commit 2026-09-04 22:35:53 +02:00
chore: explicitly pass GITHUB_TOKEN to checkout and document repository-level write permissions
Test / Run Tests (push) Successful in 5m23s
Details
Test / Run Tests (pull_request) Successful in 4m40s
Details
Philipp/Global-Workflows: Pre-commit Lint (Scoped) / pre-commit (pull_request) Successful in 1m39s
Details
39ac4100e3
AutoReview approved these changes 2026-09-04 22:35:56 +02:00
Dismissed
AutoReview left a comment
Member
Copy Link
Copy Source

Summary

  • Critical: None. The use of [skip compile] is correctly implemented to prevent recursion, and the concurrency limits in renovate.json are appropriately configured.
  • Testing: No new tests were added, but the existing workflows are now triggered on pull_request events, providing better coverage.
  • Improvement: The recompile-dist.yaml workflow correctly uses the GITHUB_TOKEN for pushing. Ensure the repository settings allow Gitea Actions to create commits (as noted in GEMINI.md).
  • Nitpick: None.

The previous review comment regarding [skip compile] has been addressed by the user in the PR implementation. This PR is ready for approval.

**Summary** * **Critical:** None. The use of `[skip compile]` is correctly implemented to prevent recursion, and the concurrency limits in `renovate.json` are appropriately configured. * **Testing:** No new tests were added, but the existing workflows are now triggered on `pull_request` events, providing better coverage. * **Improvement:** The `recompile-dist.yaml` workflow correctly uses the `GITHUB_TOKEN` for pushing. Ensure the repository settings allow Gitea Actions to create commits (as noted in `GEMINI.md`). * **Nitpick:** None. The previous review comment regarding `[skip compile]` has been addressed by the user in the PR implementation. This PR is ready for approval.
Philipp added 1 commit 2026-09-04 22:39:40 +02:00
perf: add pnpm store caching to recompile and test workflows
Philipp/Global-Workflows: Pre-commit Lint (Scoped) / pre-commit (pull_request) Successful in 2m37s
Details
Test / Run Tests (push) Successful in 5m53s
Details
Test / Run Tests (pull_request) Successful in 5m49s
Details
1e44b85b6a
AutoReview approved these changes 2026-09-04 22:39:44 +02:00
Dismissed
AutoReview left a comment
Member
Copy Link
Copy Source

Summary

  • Critical: None. The use of [skip compile] is correctly implemented to prevent recursion, and the concurrency limits in renovate.json are appropriately configured.
  • Testing: No new tests were added, but the existing workflows are now triggered on pull_request events, providing better coverage.
  • Improvement: The recompile-dist.yaml workflow correctly uses the GITHUB_TOKEN for pushing. Documentation added in GEMINI.md regarding the necessary repository settings is helpful.
  • Nitpick: None.

The previous review comments have been addressed by the user's implementation. The workflow safely handles the re-compilation trigger and provides appropriate concurrency settings for Renovate. This PR is ready for approval.

**Summary** * **Critical:** None. The use of `[skip compile]` is correctly implemented to prevent recursion, and the concurrency limits in `renovate.json` are appropriately configured. * **Testing:** No new tests were added, but the existing workflows are now triggered on `pull_request` events, providing better coverage. * **Improvement:** The `recompile-dist.yaml` workflow correctly uses the `GITHUB_TOKEN` for pushing. Documentation added in `GEMINI.md` regarding the necessary repository settings is helpful. * **Nitpick:** None. The previous review comments have been addressed by the user's implementation. The workflow safely handles the re-compilation trigger and provides appropriate concurrency settings for Renovate. This PR is ready for approval.
Philipp added 1 commit 2026-09-04 23:16:28 +02:00
chore(deps): update vitest monorepo to v4.1.11 (#121)
Recompile dist/ on Renovate PR / recompile (pull_request) Skipped
Details
Philipp/Global-Workflows: Pre-commit Lint (Scoped) / pre-commit (pull_request) Successful in 1m58s
Details
Test / Run Tests (pull_request) Successful in 3m4s
Details
Test / Run Tests (push) Successful in 3m6s
Details
4a5b36c4a2 
Test PR to verify automated recompilation of dist/.

Reviewed-on: #121
Reviewed-by: LLMReview <27+autoreview@noreplay.horstenkamp.eu>
AutoReview approved these changes 2026-09-04 23:16:30 +02:00
AutoReview left a comment
Member
Copy Link
Copy Source

Summary

  • Critical: None. The use of [skip compile] is correctly implemented to prevent recursion, and the concurrency limits in renovate.json are appropriately configured.
  • Testing: No new tests were added, but the existing workflows are now correctly triggered on pull_request events, providing better coverage.
  • Improvement: The recompile-dist.yaml workflow correctly uses the GITHUB_TOKEN for pushing. Documentation added in GEMINI.md regarding the necessary repository settings is helpful.
  • Nitpick: None.

The previous review comments have been addressed by the user's implementation. The workflow safely handles the re-compilation trigger and provides appropriate concurrency settings for Renovate. This PR is approved.

**Summary** * **Critical:** None. The use of `[skip compile]` is correctly implemented to prevent recursion, and the concurrency limits in `renovate.json` are appropriately configured. * **Testing:** No new tests were added, but the existing workflows are now correctly triggered on `pull_request` events, providing better coverage. * **Improvement:** The `recompile-dist.yaml` workflow correctly uses the `GITHUB_TOKEN` for pushing. Documentation added in `GEMINI.md` regarding the necessary repository settings is helpful. * **Nitpick:** None. The previous review comments have been addressed by the user's implementation. The workflow safely handles the re-compilation trigger and provides appropriate concurrency settings for Renovate. This PR is approved.
Philipp merged commit c08128c0ef into main 2026-09-04 23:20:17 +02:00
Philipp deleted branch feature/renovate-recompile-dist 2026-09-04 23:20:17 +02:00
Sign in to join this conversation.
Reviewers
No Reviewers
AutoReview
Labels
Clear labels
bug
Something is not working
 chore
duplicate
This issue or pull request already exists
 enhancement
New feature
 help wanted
Need some help
 invalid
Something is wrong
 question
More information is needed
 wontfix
This won't be fixed
No labels
Milestone
No items
No Milestone
Assignees
Clear assignees
AutoReview (LLMReview) Philipp (Philipp Horstenkamp) Renovate (Renovate Bot) runner (Act Runner)
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Screeps/screeps-deploy-action#120