fix(deps): update dependency glob to v14 [security] #127

Open
Renovate wants to merge 2 commits from renovate/major-14-security-updates into main
pull from: renovate/major-14-security-updates
Member

This PR contains the following updates:

Package Change Age Confidence
glob ^13.0.0 → ^14.0.0 age confidence

Glob: AbortSignal cancellation bypass allows post-timeout filesystem traversal

CVE-2026-118773 / GHSA-3g3m-2fjr-6pw4

More information

Details

Summary

In glob 13.0.6, an aborted async walk rejects or emits an error but continues recursively reading directories in the background.

The root cause is that abort branches in src/walker.ts call cb() without returning. As a result, callers that rely on signal or AbortSignal.timeout() to bound glob traversal cost can still incur filesystem I/O and CPU work after the request has already been rejected.

Details

This was reproduced on glob v13.0.6 (commit e80cb38ae60d6cbff9e75f39032a994858994d35).

The README documents that the signal option cancels the glob walk. However, in src/walker.ts, the following methods call cb() when this.signal?.aborted is true but do not return:

  • GlobUtil.walkCB()
  • GlobUtil.walkCB2()
  • GlobUtil.walkCBSync()
  • GlobUtil.walkCB2Sync()

Example vulnerable pattern:

if (this.signal?.aborted) cb()

Because execution continues after cb(), the walker still reaches processor.processPatterns(), readdirCB(), and recursive walkCB2() calls.

The issue was directly demonstrated against v13.0.6. A source-history review shows the same missing-return pattern is present in tagged releases from v9.0.0 through v13.0.6.

The issue affects both glob() and globStream().

Recommended fix:
Change each abort branch to return immediately:

if (this.signal?.aborted) return cb()

Proof of concept

Environment:

  • Linux x86_64
  • Node.js v22.23.3
  • npm 10.9.9
  • glob 13.0.6

Reproduction steps:

  1. Install the affected package:
    npm init -y
    npm install glob@13.0.6

  2. Run the attached PoC:
    node poc/abort-continues-work.mjs

The PoC aborts after the first readdir() call, waits briefly, and counts how many more directory reads happen after the promise has already rejected.

Observed output on the vulnerable version:

{
"rejection": "Error: probe-abort",
"readdirCalls": 1365,
"readdirCallsAtReject": 5,
"readdirCallsAfterReject": 1360
}

Expected behavior:
readdirCallsAfterReject should be 0.

A second PoC using AbortSignal.timeout() also reproduces the issue:

{
"rejection": "TimeoutError: The operation was aborted due to timeout",
"readdirCalls": 133,
"readdirCallsAtReject": 1,
"readdirCallsAfterReject": 132
}

The same test against a patched build with return cb() in the four abort branches stops immediately:

{
"readdirCalls": 1,
"readdirCallsAtReject": 1,
"readdirCallsAfterReject": 0
}

Impact

This is an availability issue.

Applications that expose globbing over attacker-influenced patterns or attacker-controlled directory trees and use AbortSignal / AbortSignal.timeout() as a traversal budget can still perform significant filesystem I/O and CPU work after a request has already timed out or been canceled.

Repeated timed-out requests can stack background glob walks and degrade worker throughput or service availability.

No confidentiality or integrity impact was observed.

Severity

  • CVSS Score: 6.3 / 10 (Medium)
  • Vector String: CVSS:4.0/AV:N/AC:L/AT:P/PR:N/UI:N/VC:N/VI:N/VA:L/SC:N/SI:N/SA:N

References

This data is provided by OSV and the GitHub Advisory Database (CC-BY 4.0).


Release Notes

isaacs/node-glob (glob)

v14.0.2

Compare Source

v14.0.1

Compare Source

v14.0.0

Compare Source

v13.0.7

Compare Source


Configuration

📅 Schedule: (UTC)

  • Branch creation
    • At any time (no schedule defined)
  • Automerge
    • At any time (no schedule defined)

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻ Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate CLI.

This PR contains the following updates: | Package | Change | [Age](https://docs.renovatebot.com/merge-confidence/) | [Confidence](https://docs.renovatebot.com/merge-confidence/) | |---|---|---|---| | [glob](https://github.com/isaacs/node-glob) | [`^13.0.0` → `^14.0.0`](https://renovatebot.com/diffs/npm/glob/13.0.6/14.0.2) | ![age](https://developer.mend.io/api/mc/badges/age/npm/glob/14.0.2?slim=true) | ![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/glob/13.0.6/14.0.2?slim=true) | --- ### Glob: AbortSignal cancellation bypass allows post-timeout filesystem traversal [CVE-2026-118773](https://nvd.nist.gov/vuln/detail/CVE-2026-118773) / [GHSA-3g3m-2fjr-6pw4](https://github.com/advisories/GHSA-3g3m-2fjr-6pw4) <details> <summary>More information</summary> #### Details ##### Summary In glob 13.0.6, an aborted async walk rejects or emits an error but continues recursively reading directories in the background. The root cause is that abort branches in src/walker.ts call cb() without returning. As a result, callers that rely on signal or AbortSignal.timeout() to bound glob traversal cost can still incur filesystem I/O and CPU work after the request has already been rejected. ##### Details This was reproduced on glob v13.0.6 (commit e80cb38ae60d6cbff9e75f39032a994858994d35). The README documents that the signal option cancels the glob walk. However, in src/walker.ts, the following methods call cb() when this.signal?.aborted is true but do not return: - GlobUtil.walkCB() - GlobUtil.walkCB2() - GlobUtil.walkCBSync() - GlobUtil.walkCB2Sync() Example vulnerable pattern: if (this.signal?.aborted) cb() Because execution continues after cb(), the walker still reaches processor.processPatterns(), readdirCB(), and recursive walkCB2() calls. The issue was directly demonstrated against v13.0.6. A source-history review shows the same missing-return pattern is present in tagged releases from v9.0.0 through v13.0.6. The issue affects both glob() and globStream(). Recommended fix: Change each abort branch to return immediately: if (this.signal?.aborted) return cb() ##### Proof of concept Environment: - Linux x86_64 - Node.js v22.23.3 - npm 10.9.9 - glob 13.0.6 Reproduction steps: 1. Install the affected package: npm init -y npm install glob@13.0.6 2. Run the attached PoC: node poc/abort-continues-work.mjs The PoC aborts after the first readdir() call, waits briefly, and counts how many more directory reads happen after the promise has already rejected. Observed output on the vulnerable version: { "rejection": "Error: probe-abort", "readdirCalls": 1365, "readdirCallsAtReject": 5, "readdirCallsAfterReject": 1360 } Expected behavior: readdirCallsAfterReject should be 0. A second PoC using AbortSignal.timeout() also reproduces the issue: { "rejection": "TimeoutError: The operation was aborted due to timeout", "readdirCalls": 133, "readdirCallsAtReject": 1, "readdirCallsAfterReject": 132 } The same test against a patched build with return cb() in the four abort branches stops immediately: { "readdirCalls": 1, "readdirCallsAtReject": 1, "readdirCallsAfterReject": 0 } ##### Impact This is an availability issue. Applications that expose globbing over attacker-influenced patterns or attacker-controlled directory trees and use AbortSignal / AbortSignal.timeout() as a traversal budget can still perform significant filesystem I/O and CPU work after a request has already timed out or been canceled. Repeated timed-out requests can stack background glob walks and degrade worker throughput or service availability. No confidentiality or integrity impact was observed. #### Severity - CVSS Score: 6.3 / 10 (Medium) - Vector String: `CVSS:4.0/AV:N/AC:L/AT:P/PR:N/UI:N/VC:N/VI:N/VA:L/SC:N/SI:N/SA:N` #### References - [https://github.com/isaacs/node-glob/security/advisories/GHSA-3g3m-2fjr-6pw4](https://github.com/isaacs/node-glob/security/advisories/GHSA-3g3m-2fjr-6pw4) - [https://nvd.nist.gov/vuln/detail/CVE-2026-118773](https://nvd.nist.gov/vuln/detail/CVE-2026-118773) - [https://github.com/isaacs/node-glob/commit/4682e8c9babee1b385202ede36389634e12076d7](https://github.com/isaacs/node-glob/commit/4682e8c9babee1b385202ede36389634e12076d7) - [https://github.com/isaacs/node-glob](https://github.com/isaacs/node-glob) - [https://github.com/isaacs/node-glob/releases/tag/v14.0.2](https://github.com/isaacs/node-glob/releases/tag/v14.0.2) This data is provided by [OSV](https://osv.dev/vulnerability/GHSA-3g3m-2fjr-6pw4) and the [GitHub Advisory Database](https://github.com/github/advisory-database) ([CC-BY 4.0](https://github.com/github/advisory-database/blob/main/LICENSE.md)). </details> --- ### Release Notes <details> <summary>isaacs/node-glob (glob)</summary> ### [`v14.0.2`](https://github.com/isaacs/node-glob/compare/v14.0.1...v14.0.2) [Compare Source](https://github.com/isaacs/node-glob/compare/v14.0.1...v14.0.2) ### [`v14.0.1`](https://github.com/isaacs/node-glob/compare/v14.0.0...v14.0.1) [Compare Source](https://github.com/isaacs/node-glob/compare/v14.0.0...v14.0.1) ### [`v14.0.0`](https://github.com/isaacs/node-glob/compare/v13.0.7...v14.0.0) [Compare Source](https://github.com/isaacs/node-glob/compare/v13.0.7...v14.0.0) ### [`v13.0.7`](https://github.com/isaacs/node-glob/compare/v13.0.6...v13.0.7) [Compare Source](https://github.com/isaacs/node-glob/compare/v13.0.6...v13.0.7) </details> --- ### Configuration 📅 **Schedule**: (UTC) - Branch creation - At any time (no schedule defined) - Automerge - At any time (no schedule defined) 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate CLI](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0NC4xOTAuMCIsInVwZGF0ZWRJblZlciI6IjQ0LjIxMC4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJzZWN1cml0eSJdfQ==-->
Renovate added 1 commit 2026-10-31 20:54:56 +01:00
fix(deps): update dependency glob to v14 [security]
renovate/stability-days Updates have met minimum release age requirement
Recompile dist/ on Renovate PR / recompile (pull_request) Successful in 8m51s
Test / Run Tests (push) Successful in 13m45s
Test / Run Tests (pull_request) Successful in 10m51s
Philipp/Global-Workflows: Pre-commit Lint (Scoped) / pre-commit (pull_request) Successful in 2m44s
815d874ef7
CODEOWNERS rules requested review from AutoReview 2026-10-31 20:54:56 +01:00
gitea-actions Bot added 1 commit 2026-10-31 21:21:06 +01:00
chore: compile action bundle [skip compile]
renovate/stability-days Updates have met minimum release age requirement
a7b994f1bd
Some checks are pending
renovate/stability-days Updates have met minimum release age requirement
Philipp/Global-Workflows: Pre-commit Lint (Scoped) / pre-commit (pull_request)
Required
Test / *
Required
Some required checks are missing.
You are not authorized to merge this pull request.
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin renovate/major-14-security-updates:renovate/major-14-security-updates
git checkout renovate/major-14-security-updates
Sign in to join this conversation.
No Reviewers
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Screeps/screeps-deploy-action#127