Screeps/screeps-deploy-action
4
1
Fork 0
Code Issues 1 Pull Requests Actions Packages Releases Activity

Remove unused pre-commit hooks #61

Merged
Philipp merged 1 commits from chore/pre-commit-cleanup into main 2026-01-04 23:48:11 +01:00
Conversation 2 Commits 1 Files Changed 1 -8
Philipp commented 2026-01-04 07:15:18 +01:00
Owner
Copy Link

PR Type

Enhancement

Description

  • Remove unused pre-commit hooks

  • Delete pretty-format-ini and pretty-format-toml

File Walkthrough
Relevant files
Configuration changes
.pre-commit-config.yaml
Clean up pre-commit hook configuration                                     

.pre-commit-config.yaml

  • Removed pretty-format-ini hook entry
  • Removed pretty-format-toml hook entry
 +0/-8     
### **PR Type** Enhancement ___ ### **Description** - Remove unused pre-commit hooks - Delete `pretty-format-ini` and `pretty-format-toml` ___ <details> <summary><h3> File Walkthrough</h3></summary> <table><thead><tr><th></th><th align="left">Relevant files</th></tr></thead><tbody><tr><td><strong>Configuration changes</strong></td><td><table> <tr> <td> <details> <summary><strong>.pre-commit-config.yaml</strong><dd><code>Clean up pre-commit hook configuration</code>&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; </dd></summary> <hr> .pre-commit-config.yaml <ul><li>Removed <code>pretty-format-ini</code> hook entry<br> <li> Removed <code>pretty-format-toml</code> hook entry</ul> </details> </td> <td><a href="https://git.horstenkamp.eu/Screeps/screeps-deploy-action/src/branch/chore/pre-commit-cleanup/.pre-commit-config.yaml">+0/-8</a>&nbsp; &nbsp; &nbsp; </td> </tr> </table></td></tr></tr></tbody></table> </details> ___
Philipp added the chore label 2026-01-04 07:15:18 +01:00
Philipp self-assigned this 2026-01-04 07:15:18 +01:00
Philipp added 1 commit 2026-01-04 07:15:20 +01:00
chore: remove unused pre-commit hooks
Some checks failed
Lint / pre-commit Linting (push) Successful in 1m16s
Details
Test / Run Tests (push) Failing after 12m52s
Details
a7f67bacec
AutoReview changed title from chore: remove unused pre-commit hooks to Remove unused pre-commit hooks 2026-01-04 07:16:01 +01:00
AutoReview commented 2026-01-04 07:16:27 +01:00
Member
Copy Link

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪
🧪 No relevant tests
🔒 No security concerns identified
⚡ Recommended focus areas for review

Config Consistency

Verify that removal of pretty-format-ini and pretty-format-toml does not leave dangling references in any CI scripts, lockfiles, or documentation, and update those if necessary.

 
- repo: https://github.com/macisamuele/language-formatters-pre-commit-hooks
  rev: v2.15.0
  hooks:
  - id: pretty-format-yaml
    args: [--autofix]
Formatting Coverage

Ensure that ini and toml files are still formatted by another tool or hook if needed, so no configuration files slip through unformatted.

 
- repo: https://github.com/macisamuele/language-formatters-pre-commit-hooks
  rev: v2.15.0
  hooks:
  - id: pretty-format-yaml
    args: [--autofix]
## PR Reviewer Guide 🔍 Here are some key observations to aid the review process: <table> <tr><td>⏱️&nbsp;<strong>Estimated effort to review</strong>: 1 🔵⚪⚪⚪⚪</td></tr> <tr><td>🧪&nbsp;<strong>No relevant tests</strong></td></tr> <tr><td>🔒&nbsp;<strong>No security concerns identified</strong></td></tr> <tr><td>⚡&nbsp;<strong>Recommended focus areas for review</strong><br><br> <details><summary><a href='https://git.horstenkamp.eu/Screeps/screeps-deploy-action/src/branch/chore/pre-commit-cleanup/.pre-commit-config.yaml#L19-L24'><strong>Config Consistency</strong></a> Verify that removal of `pretty-format-ini` and `pretty-format-toml` does not leave dangling references in any CI scripts, lockfiles, or documentation, and update those if necessary. </summary> ```yaml - repo: https://github.com/macisamuele/language-formatters-pre-commit-hooks rev: v2.15.0 hooks: - id: pretty-format-yaml args: [--autofix] ``` </details> <details><summary><a href='https://git.horstenkamp.eu/Screeps/screeps-deploy-action/src/branch/chore/pre-commit-cleanup/.pre-commit-config.yaml#L19-L24'><strong>Formatting Coverage</strong></a> Ensure that ini and toml files are still formatted by another tool or hook if needed, so no configuration files slip through unformatted. </summary> ```yaml - repo: https://github.com/macisamuele/language-formatters-pre-commit-hooks rev: v2.15.0 hooks: - id: pretty-format-yaml args: [--autofix] ``` </details> </td></tr> </table>
AutoReview commented 2026-01-04 07:16:30 +01:00
Member
Copy Link

PR Code Suggestions ✨

No code suggestions found for the PR.

## PR Code Suggestions ✨ No code suggestions found for the PR.
Philipp force-pushed chore/pre-commit-cleanup from a7f67bacec to f786e320f4 2026-01-04 07:28:40 +01:00 Compare
Philipp merged commit c5a58026fa into main 2026-01-04 23:48:11 +01:00
Philipp deleted branch chore/pre-commit-cleanup 2026-01-04 23:48:15 +01:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
bug
Something is not working
 chore
duplicate
This issue or pull request already exists
 enhancement
New feature
 help wanted
Need some help
 invalid
Something is wrong
 question
More information is needed
 wontfix
This won't be fixed
No Label chore
Milestone
No items
No Milestone
Assignees
Clear assignees
AutoReview Philipp Renovate runner
No Assignees Philipp
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Screeps/screeps-deploy-action#61
Delete Branch "chore/pre-commit-cleanup"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?